Skip to content

feat: support aweXpect repos #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vbreuss merged 4 commits into from
Nov 25, 2024
Merged

feat: support aweXpect repos #11

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d6df31c
Update PullRequestStatusCheckController.cs
vbreuss Nov 25, 2024
3afb517
Update PullRequestStatusCheckController.cs
vbreuss Nov 25, 2024
67c1429
Merge branch 'main' into topic/allow-awexpect-repos
vbreuss Nov 25, 2024
3fb6dc1
Update PullRequestStatusCheckController.cs
vbreuss Nov 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions Source/Testably.Server/Controllers/PullRequestStatusCheckController.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
[AllowAnonymous]
public class PullRequestStatusCheckController : ControllerBase
{
private const string RepositoryOwner = "Testably";
private static readonly string[] RepositoryOwners = ["Testably", "aweXpect"];

private const string SuccessMessage =
"The PR title must conform to the conventional commits guideline.";
Expand Down Expand Up @@ -62,15 +62,15 @@
}

if (pullRequestModel.Repository.Private ||
pullRequestModel.Repository.Owner.Login != RepositoryOwner)
RepositoryOwners.All(repositoryOwner => pullRequestModel.Repository.Owner.Login != repositoryOwner))
{
return BadRequest($"Only public repositories from '{RepositoryOwner}' are supported!");
return BadRequest($"Only public repositories from '{string.Join(", ", RepositoryOwners)}' are supported!");
}

var bearerToken = _configuration.GetValue<string>("GithubBearerToken");
using var client = _clientFactory.CreateClient("Proxied");
client.DefaultRequestHeaders.UserAgent.Add(new ProductInfoHeaderValue("Testably",
Assembly.GetExecutingAssembly().GetName().Version.ToString()));

Check warning on line 73 in Source/Testably.Server/Controllers/PullRequestStatusCheckController.cs

View workflow job for this annotation

GitHub Actions / build 

Dereference of a possibly null reference.

Check warning on line 73 in Source/Testably.Server/Controllers/PullRequestStatusCheckController.cs

View workflow job for this annotation

GitHub Actions / build 

Dereference of a possibly null reference.
client.DefaultRequestHeaders.Authorization =
new AuthenticationHeaderValue("Bearer", bearerToken);

Expand Down