[dpl] support yieldable log processing #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On higher optimization levels, instruction reordering can occur across boundary of reading peripheral clock div register
On higher optimization levels, instruction reordering can occur across boundary of reading peripheral clock div register
cmattatall
requested review from
shiva-ti and
venkatesan-krishnamoorthy
as code owners
cmattatall
force-pushed
the
dpl/yieldable-log-reader
branch
from
5061ed6 to
2c28474
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are many scenarios where the core performing log processing is also performing other I/O bound workloads and the log processing is not the highest priority task.
This PR preserves the default behavior of
DebugP_shm_log_reader(reading all available logs, blocking until all are processed) but exposes an API that allows yielding and after a certain number of lines have been processed.