mpl: consider data flow connections during macro placement #7472
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arthur Koucher <arthurkoucher@precisioninno.com>
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Contributor
Author
|
Running Secure-CI. |
maliberty
approved these changes
Jun 2, 2025
Member
maliberty
left a comment
maliberty
left a comment
There was a problem hiding this comment.
The code changes are simple, its just about the CI
Signed-off-by: Arthur Koucher <arthurkoucher@precisioninno.com>
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Contributor
Author
|
Secure-CI passed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #7435
Context
Mock-array had poor macro placement results with the new floorplan rebuffering. Some investigation showed that the nets between macros and IOs were not being considered, because the data flow connections are not taken into account during the macro placement step inside MPL. The changes here are not enough to make MPL able to handle mock-array with the new rebuffering.
Also did some renaming to clarify what is going on.