Allow to print pdf #20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request introduces the ability to print PDF by allowing a function to be passed for PDF printing, along with some minor updates to the release notes and CI configuration.
- Updated NEWS.md to include release notes about the PDF printing functionality
- Adjusted GitHub Actions workflow to include the "dev" branch for push and pull_request events
Reviewed Changes
Copilot reviewed 2 out of 6 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| NEWS.md | Updated release notes to mention printing output to PDF |
| .github/workflows/R-CMD-check.yaml | Added "dev" branch to the CI trigger configurations |
Files not reviewed (4)
- DESCRIPTION: Language not supported
- R/compile_qmd_course.R: Language not supported
- man/compile_qmd_course.Rd: Language not supported
- tests/testthat/test-compile_qmd_course.R: Language not supported
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
ColinFay
commented
Apr 1, 2025
Member
Author
ColinFay
left a comment
ColinFay
left a comment
There was a problem hiding this comment.
Everything good mate 🫶
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #20 +/- ##
==========================================
+ Coverage 98.94% 98.96% +0.01%
==========================================
Files 12 12
Lines 378 385 +7
==========================================
+ Hits 374 381 +7
Misses 4 4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ColinFay
added a commit
that referenced
this pull request
Apr 22, 2025
* ci: testing in dev too * feat: allow to print_pdf * test: testing pdf printing * chore: version bump & news * Update NEWS.md Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can now pass a function that will print to pdf