Skip to content

Conversation

@shaunrd0
Copy link
Member

This adds a binding for DeserializeArrayCreate to support deserializing the new ArrayCreateRequest model added in CLOUD-951

@shaunrd0 shaunrd0 requested a review from a team as a code owner July 10, 2025 17:29
@shaunrd0 shaunrd0 changed the title Shaunreed/cloud 951 adapt arraycreatehandler to process non default storage Add binding for DeserializeArrayCreate. Jul 10, 2025
@teo-tsirpanis
Copy link
Member

You need to temporarily point to your fork TileDB-Go too.

@ypatia
Copy link
Member

ypatia commented Jul 11, 2025

You need to temporarily point to your fork TileDB-Go too.

I guess Theo means that those changes shouldn't be here, but in your fork and you'd like to point to your fork from the other project.

ypatia
ypatia previously requested changes Jul 17, 2025
Copy link
Member

@ypatia ypatia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's not merge this before we revert the changes in the Core branches - aka before the Core release that introduces that new API is issued.

@shaunrd0 shaunrd0 force-pushed the shaunreed/cloud-951-adapt-arraycreatehandler-to-process-non-default-storage branch from b3d91d7 to a20207d Compare July 22, 2025 15:33
@shaunrd0
Copy link
Member Author

2.28.1 is currently in use on master, the patched core release has been removed from this PR. Once this is merged we can continue with the TileDB-Go release.

@shaunrd0 shaunrd0 requested review from teo-tsirpanis and ypatia July 22, 2025 15:38
@teo-tsirpanis teo-tsirpanis dismissed ypatia’s stale review July 22, 2025 15:39

Feedback addressed.

@shaunrd0 shaunrd0 merged commit 5864ce8 into master Jul 22, 2025
8 checks passed
@teo-tsirpanis teo-tsirpanis deleted the shaunreed/cloud-951-adapt-arraycreatehandler-to-process-non-default-storage branch July 22, 2025 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants