Users can subscribe to the calendar #647

himynameismoose · 2025-08-31T18:35:26Z

Description

Issue #628: Added a button to the Calendar UI for users to subscribe to by adding the Together calendar to their personal calendar.

Dependencies added:
"ics": "^3.8.1"

Type of change

Please select everything applicable. Please, do not delete any lines.

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update
This change requires an update to testing

Issue

Is this related to a specific issue? If so, please specify: Resolves Users can subscribe to the calendar #628

Checklist:

This PR is up to date with the main branch, and merge conflicts have been resolved
I have executed npm run test and npm run test:e2e and all tests have passed successfully or I have included details within my PR on the failure.

I have executed npm run lint and resolved any outstanding errors. Most issues can be solved by executing npm run format

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
My changes generate no new warnings

package.json

server/routes/calendar.js

20jasper · 2025-08-31T20:41:34Z

server/routes/calendar.js

+
+module.exports = (app) => {
+  app.get("/calendar.ics", async (req, res) => {
+    try {


Not exactly sure how testing goes in this project, but I think it'd be good to write a test to make sure the ICS file is generated appropriately

Glad to help out on approach if you'd like!

Thanks for the suggestion, and I agree that writing a test for this is important.

I'll add a server-side test that will make a GET request to the /calendar.ics endpoint and verify that the response status is 200, as well as that the Content-Type header is set to "text/calendar".

Would this be a good starting ground?

Yep! Once you get that working, you can also check things like the filename and that the appropriate events are included in the ICS file!

It seems ics is for generating ics files and not parsing them, so you may need to include a dev dependency to validate or consider a library that does both

I've attempted to write tests for my calendar.test.js. I ran npm test and all tests passed. However, I've had to make some changes to some other files under the test directory, along with my calendar.js route file. I am a bit wary of this result since there are errors generating in the console even though the tests all pass. Could I have a moment of your time to look through my new changes before I even consider committing?

server/routes/calendar.js

alcpereira · 2025-09-02T18:03:32Z

server/routes/calendar.js

+const ics = require("ics");
+const Event = require("../models/Event");
+
+const createDateArray = (date) => {


Since we have date-fns available we can use it, similar to what they used in the docs with moment (source).

I have made changes to import the format function from date-fns and will be included in my next commit.

alcpereira · 2025-09-02T18:16:43Z

server/routes/calendar.js

+          // use createDateArray helper function
+          start: createDateArray(startDate),
+          end: createDateArray(endDate),
+          url: `https://together.rocks/events/${event._id}`,


This URL /events/:id does not work at the moment. Should we just send back the users to the /calendar page in the mean time?

agree, hopefully we will get this behavior with #618

I made changes to the url to send users to /calendar and will be included in my next commit.

alcpereira · 2025-09-02T18:22:00Z

server/routes/calendar.js

+  app.get("/calendar.ics", async (req, res) => {
+    try {
+      // fetch events from mongodb
+      const eventsFromDB = await Event.find().lean();


From an user perspective, does it make sense to include all the events from the database?

We can proceed with this as the first iteration, but it's worth discussing for a future improvement.

would this include past events as well? maybe we at least filter for events after the current date

oh i did not take this into consideration! thanks for the suggestion. i'll put it on the back-burner for now and prioritize the .ics creation.

alcpereira · 2025-09-02T18:25:29Z

server/routes/calendar.js

+          // use createDateArray helper function
+          start: createDateArray(startDate),
+          end: createDateArray(endDate),
+          url: `https://together.rocks/events/${event._id}`,


Non blocker, but on the long run we need to think about together.rocks being hardcoded (tests, preview PR, change of domain, etc), same for the other <a> link in the client.

alcpereira · 2025-09-02T18:26:59Z

server/routes/calendar.js

+      const eventsFromDB = await Event.find().lean();
+      // format events for the ics library
+      const icsEvents = eventsFromDB.map((event) => {
+        const startDate = event.startAt;


Why not destructure the whole object?

i have refactored the map function to use object destructuring. i will include these changes in my next commit

DevinCLane · 2025-09-02T22:17:20Z

super good overall and thank you for the contribution @himynameismoose, welcome in!

himynameismoose · 2025-10-07T23:43:48Z

srpt3.mp4

himynameismoose requested review from DevinCLane, alcpereira, emmebravo, funbunch, intelagense and merrua as code owners August 31, 2025 18:35

himynameismoose force-pushed the feature/issue-628 branch from f69bd35 to ca1f85e Compare August 31, 2025 19:18

20jasper reviewed Aug 31, 2025

View reviewed changes

package.json Show resolved Hide resolved

20jasper reviewed Aug 31, 2025

View reviewed changes

server/routes/calendar.js Outdated Show resolved Hide resolved

20jasper reviewed Aug 31, 2025

View reviewed changes

himynameismoose force-pushed the feature/issue-628 branch 2 times, most recently from bd645bf to be2e602 Compare August 31, 2025 21:05

DevinCLane requested changes Sep 2, 2025

View reviewed changes

server/routes/calendar.js Outdated Show resolved Hide resolved

alcpereira reviewed Sep 2, 2025

View reviewed changes

himynameismoose force-pushed the feature/issue-628 branch from be2e602 to f3c0143 Compare September 15, 2025 02:29

himynameismoose changed the title ~~Feature/issue 628~~ Users can subscribe to the calendar Sep 22, 2025

feat: Implement calendar subscription feature

0196813

himynameismoose force-pushed the feature/issue-628 branch from f3c0143 to 0196813 Compare October 7, 2025 22:16

himynameismoose requested a review from moses-codes as a code owner October 7, 2025 22:16

Users can subscribe to the calendar #647

Are you sure you want to change the base?

Users can subscribe to the calendar #647

Uh oh!

Conversation

himynameismoose commented Aug 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Type of change

Issue

Checklist:

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

DevinCLane Sep 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

himynameismoose Sep 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

DevinCLane commented Sep 2, 2025

Uh oh!

himynameismoose commented Oct 7, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

himynameismoose commented Aug 31, 2025 •

edited

Loading

DevinCLane Sep 2, 2025 •

edited

Loading

himynameismoose Sep 2, 2025 •

edited

Loading