Skip to content

Conversation

@christolis
Copy link
Member

Why

Sonarlint wants every public class to have a JavaDoc.

Signed-off-by: Chris Sdogkos <work@chris-sdogkos.com>
@christolis christolis requested a review from a team as a code owner January 4, 2026 10:16
Write an improved, more specific JavaDoc for VoiceReceiverAdapter.

Signed-off-by: Chris Sdogkos <work@chris-sdogkos.com>
@tj-wazei
Copy link
Contributor

tj-wazei commented Jan 4, 2026

  • {@link #onVoiceUpdate(GuildVoiceUpdateEvent)} like the other provided methods can be overridden
  • if desired. The default implementation is empty, the adapter will not react to such events.

Seems unnecessary but approved anyway, the intent is there.

But if you want to make it better...

This class follows the adapter pattern: it provides empty (no-op) implementations for all {@link VoiceReceiver} callback methods, allowing subclasses to override only the events they are interested in.

@christolis christolis merged commit fb6cbf7 into Together-Java:develop Jan 4, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants