Option to clear past errors from workflow state #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Tom-Newton
force-pushed
the
tomnewton/remove_error_messages_from_crd
branch
from
62f6154 to
2b76a91
Compare
Tom-Newton
force-pushed
the
tomnewton/collapse_sub_nodes_on_failures
branch
from
05208ec to
64d7fa2
Compare
Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com>
Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com>
This reverts commit dab428d. Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com>
…rrors Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com>
Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com>
Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com>
Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com>
Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com>
Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com>
Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com>
Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com>
Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com>
Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com>
Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com>
Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com>
Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com>
Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com>
Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com>
Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com>
Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com>
Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com>
Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com>
Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com>
Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com>
Tom-Newton
force-pushed
the
tomnewton/remove_error_messages_from_crd
branch
from
2b76a91 to
216e1a3
Compare
Tom-Newton
changed the base branch from
tomnewton/collapse_sub_nodes_on_failures
to
master
Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com>
Tom-Newton
force-pushed
the
tomnewton/remove_error_messages_from_crd
branch
from
852f527 to
6c5650c
Compare
Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com>
Tom-Newton
force-pushed
the
tomnewton/remove_error_messages_from_crd
branch
from
f7c5f80 to
2cea075
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
flyteorg#4569
Why are the changes needed?
Reduce un-needed information stored in etcd when using
failure_policy=WorkflowFailurePolicy.FAIL_AFTER_EXECUTABLE_NODES_COMPLETE. This allows flyte to scale to larger workflows before hitting etcd size limits.What changes were proposed in this pull request?
FAIL_AFTER_EXECUTABLE_NODES_COMPLETEdelete the previous error from the workflow state every time a new error occurs.clear-previous-errorwhich defaults tofalse(maintaining the original behaviour).TestWorkflowExecutor_HandleFlyteWorkflow_Failingtest so that more than one node fails.TestWorkflowExecutor_HandleFlyteWorkflow_Failingfor all the combinations ofOnFailurePolicyandclear-previous-error.How was this patch tested?
Updated unittests
Setup process
Screenshots
Check all the applicable boxes
clear-state-on-any-terminationandclear-previous-errorin https://docs.flyte.org/en/latest/deployment/configuration/performance.html#improving-etcd-performanceRelated PRs
This is part 2
Part 1 was implemented by flyteorg#4596
Docs link