feat: add webhooks #4
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
null8626
force-pushed
the
split/webhooks
branch
from
5d1046a to
1414dff
Compare
velddev
reviewed
Sep 17, 2025
Collaborator
velddev
left a comment
velddev
left a comment
There was a problem hiding this comment.
just use https://github.com/daurnimator/lua-http 😐
topgg/lib/webhooks.lua
Outdated
| socket:on('data', function(chunk) | ||
| body = body .. chunk | ||
|
|
||
| if body:find('\r\n\r\n') then |
Collaborator
There was a problem hiding this comment.
Why are we manually searching through a data payload? 😅 Is there really no better way in lua than a raw tls socket?
Member
Author
This SDK uses the |
null8626
force-pushed
the
split/webhooks
branch
from
5e86330 to
d4f7ce3
Compare
null8626
force-pushed
the
split/webhooks
branch
from
d4f7ce3 to
65b5206
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following pull request is a toned down version of #3. This pull request focuses solely on adding a webhooks wrapper.