Support ignorable platform properties #2120
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcusSorealheis
approved these changes
Jan 26, 2026
MarcusSorealheis
added a commit
that referenced
this pull request
Jan 26, 2026
…d-worker-registration * 'main' of github.com:TraceMachina/nativelink: Support ignorable platform properties (#2120)
MarcusSorealheis
added a commit
to MarcusSorealheis/nativelink
that referenced
this pull request
Jan 26, 2026
…d-worker-registration * 'main' of github.com:TraceMachina/nativelink: output_files can be very noisy, drop from debug (TraceMachina#2123) Support ignorable platform properties (TraceMachina#2120)
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In certain cases (Chromium builds with
InputRootAbsolutePathare a good example here), builds provide extra properties that they want workers to have. However, some of these properties are ignorable, especially if say all your workers match the criteria. Right now however, Nativelink requires at a minimum for all workers to have all properties specified in the job, even if they're not needed.Type of change
Please delete options that aren't relevant.
How Has This Been Tested?
Manual running
Checklist
bazel test //...passes locallygit amendsee some docsThis change is