Be clearer about what property values workers are missing #2121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
palfrey
commented
Jan 26, 2026
| // No properties required, all workers match | ||
| return self.all_workers.clone(); | ||
| } | ||
|
|
Member
Author
There was a problem hiding this comment.
These two got swapped over. In the "you have no workers case" the return value won't change, but it'll be a bit clearer as to why nothing is getting scheduled.
palfrey
commented
Jan 26, 2026
| if full_worker_logging { | ||
| info!( | ||
| "No candidate workers due to a lack of matching {name} = {value:?}" | ||
| "No candidate workers due to a lack of matching '{name}' = {value:?}" |
Member
Author
There was a problem hiding this comment.
Otherwise you got things like due to a lack of key os and this more clearly delineates between the key and the message.
palfrey
commented
Jan 26, 2026
| info!("No candidate workers due to a lack of key {name}"); | ||
| info!( | ||
| "No candidate workers due to a lack of key '{name}'. Job asked for {value:?}" | ||
| ); |
Member
Author
There was a problem hiding this comment.
This is the main addition, as errors like No candidate workers due to a lack of key InputRootAbsolutePath are hard to fix without knowing what value the jobs are looking for.
palfrey
force-pushed
the
improved-missing-property-logging
branch
from
e6cbec7 to
adead3b
Compare
palfrey
force-pushed
the
improved-missing-property-logging
branch
from
adead3b to
dc4eb45
Compare
Collaborator
|
/build-image |
|
Image built and pushed! |
Member
Author
|
/build-image nativelink-worker-init |
|
Image built and pushed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#2118 added logging around missing worker properties, but you still have cases where you don't know what property value should actually be set on the workers! This PR improves that.
Type of change
Please delete options that aren't relevant.
How Has This Been Tested?
bazel test //...mostly.Checklist
bazel test //...passes locallygit amendsee some docsThis change is