Add virtual MIDI port infrastructure #110
Open
+201
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Creates a single virtual MIDI port ("piStomp-MIDI") for all hardware
controls to send MIDI messages through. This consolidates MIDI routing
and enables automatic JACK bridging in separated mode.
Changes:
- Add VirtualMidiPort class managing amidithru subprocess lifecycle
- Update modalapistomp.py to create virtual port at startup
- Remove unused rtmidi import from analogmidicontrol.py
- All hardware controls now send to single virtual port
The virtual port is created early in startup, discovered via rtmidi,
and cleaned up gracefully on exit. JACK auto-connects to this port
for MIDI Learn in separated mode.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates a single virtual MIDI port ("piStomp-MIDI") for all hardware controls to send MIDI messages through, rather than using the pre-existing "Midi Through" ALSA port. This way we can forward / filter / modify the ones we want via the MIDI routing in the pedalboard, and the parameters still work for MIDI Learn.
Changes:
amidithrusubprocess lifecycleThe virtual port is created early in startup, discovered via rtmidi, and cleaned up gracefully on exit. JACK auto-connects to this port for MIDI Learn in separated mode.
Stacked PRs: