Allow multiple [CleanUtility(...)] annotations per class

[TonyTroeff]

Pull Request Description

This pull request introduces support for allowing multiple [CleanUtility(...)] annotations on the same class, enhancing the functionality and flexibility of the CleanUtility attribute.

Motivation and Context

Previously, it was only possible to use a single [CleanUtility(...)] annotation per class, which could be limiting for more complex scenarios requiring multiple attributes. This change provides more versatility.

Checklist

• I have tested these changes thoroughly.
• I have added/updated relevant documentation.
• My code follows the project's coding guidelines.
• I have performed a self-review of my changes.
• My changes are backwards compatible.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[Copilot]

Pull request overview

This PR enables multiple [CleanUtility(...)] annotations on the same class by changing the AllowMultiple parameter from false to true in the CleanUtilityAttribute. The existing code in CleanTestFramework.cs already supports iteration over multiple attributes, so the change enables a previously disabled capability.

Changes:

• Modified CleanUtilityAttribute to allow multiple instances per class (AllowMultiple = true)
• Renamed local variable from initializationUtilityAttributes to cleanUtilityAttributes for better consistency with the attribute name

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File	Description
TryAtSoftware.CleanTests.Core/Attributes/CleanUtilityAttribute.cs	Updated AttributeUsage to allow multiple annotations per class
TryAtSoftware.CleanTests.Core/XUnit/CleanTestFramework.cs	Renamed variable for consistency (functionality already supported multiple attributes)

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

While allowing multiple CleanUtility attributes on the same class is technically supported by the registration code, there's a critical constraint that needs to be documented: each attribute on the same class must have a unique combination of Category and Name. The utility ID is computed as "c:{Category}|n:{Name}" (see ICleanUtilityDescriptor interface), and duplicate IDs will cause a runtime exception during registration (see CleanTestAssemblyData constructor line 33: "Two clean utilities with the same identifier cannot co-exist."). Consider adding this constraint to the attribute's documentation or implementing validation to provide a clearer error message when duplicate combinations are detected.

[Copilot]

The variable has been renamed from 'initializationUtilityAttributes' to 'cleanUtilityAttributes' for consistency with the attribute name. However, this is only a partial renaming - the variable 'initializationUtility' at line 86 still uses the old naming convention. Consider renaming it to 'cleanUtility' or 'cleanUtilityDescriptor' for consistency throughout the method.

[Copilot]

This feature enhancement lacks test coverage. While the existing code can handle multiple attributes through iteration, there are no tests validating this new capability. Consider adding tests that cover: (1) successfully registering a class with multiple CleanUtility attributes with different category/name combinations, (2) verifying that duplicate category/name combinations on the same class are properly rejected, and (3) ensuring that utilities registered through multiple attributes are correctly available for test discovery and execution.