fix(lookup): parse reservedFor from on-chain state #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix reservation information extraction in `resolve` method by reading from actual on-chain state field 'i.reservedOwner.a' instead of verified properties. This enables proper NFD claiming functionality for reserved NFDs. Previously, `reservedFor` was incorrectly sourced from verified properties which do not contain the reservation data. Now correctly parses the reservation address from global state and adds it to both top-level NFD object and internal properties for consistent access patterns.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes reservation information extraction in the
resolvemethod by reading from the actual on-chain state fieldi.reservedOwner.ainstead of verified properties. This enables proper NFD claiming functionality for reserved NFDs.Details
reservedForparsing fromverified['reservedFor']toparseAddress('i.reservedOwner.a', globalState)reservedForproperty to NFD objects for consistent accessproperties.internal.reservedOwnerproperty as alternative access path