-
Notifications
You must be signed in to change notification settings - Fork 89
Improve compilesim.py test coverage #458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## development #458 +/- ##
=============================================
+ Coverage 91.4% 91.7% +0.4%
=============================================
Files 24 24
Lines 6413 6413
=============================================
+ Hits 5858 5878 +20
+ Misses 555 535 -20 ☔ View full report in Codecov by Sentry. |
fdxmw
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the pull request, looks good overall! I have some minor style comments, and there are a couple pycodestyle errors in the presubmit checks too:
tests/test_compilesim.py:948:1: W293 blank line contains whitespace
tests/test_compilesim.py:951:1: W293 blank line contains whitespace
|
@fdxmw fixed |
I added more tests to improve the test coverage of
compilesim.py:test_less_than_cmp_simulationandtest_equals_simulationto cover functions_build_eqand_build_cmpincompilesim.py_romwidthincompilesim.pytest_rom_romblock_in_memory_value_map_errorto test the exceptionraise PyrtlError('RomBlock in memory_value_map')(line 781 incompilesim.py)