Remove the restriction on Package in Package() data structure #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edhay
force-pushed
the
main
branch
2 times, most recently
from
435c202 to
c2bed2d
Compare
Restriction on Package in Package() data structure is removed accommodating it to contain nested packages Additional clarification added See issue UEFI#29 for more details.
rafaeljw
reviewed
Nov 25, 2025
| * a Package consisting entirely of Integer, String, or Reference objects | ||
| (and specifically not containing a nested Package). | ||
| * a Reference (but not referencing a Package which in turn contains nested Package references), or | ||
| * a Package (but not containing a reference to another Package). |
There was a problem hiding this comment.
"A reference to a Package" is not particularly well defined as far as I can say. If the name (or generally a namepath) of an object appears in the source code, which is regarded as a "reference" to that object, there are two cases. If it is possible to evaluate it, it will be evaluated and the return value (whatever it is) will be used where the name has appeared. If it cannot be evaluated, it will be held as a "reference object" (this happens if the target object is a device, for example). Objects that evaluate to Packages are in the first category, so they are evaluated in that case and the Package appears where the name has been used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restriction on Package in Package() data structure is removed accommodating it to contain nested packages
See issue #29 for more details.