fix: add tests for parallel branches with triggers #380
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cristipufu
force-pushed
the
fix/resumable_tests
branch
2 times, most recently
from
fec857b to
af306bd
Compare
Comment on lines
+358
to
+373
| # Define nodes that interrupt twice sequentially | ||
| def branch_a_first(state: State) -> State: | ||
| result = interrupt({"message": "Branch A - First interrupt"}) | ||
| return {"branch_a_first_result": f"A-1 completed with: {result}"} | ||
|
|
||
| def branch_a_second(state: State) -> State: | ||
| result = interrupt({"message": "Branch A - Second interrupt"}) | ||
| return {"branch_a_second_result": f"A-2 completed with: {result}"} | ||
|
|
||
| def branch_b_first(state: State) -> State: | ||
| result = interrupt({"message": "Branch B - First interrupt"}) | ||
| return {"branch_b_first_result": f"B-1 completed with: {result}"} | ||
|
|
||
| def branch_b_second(state: State) -> State: | ||
| result = interrupt({"message": "Branch B - Second interrupt"}) | ||
| return {"branch_b_second_result": f"B-2 completed with: {result}"} |
Contributor
There was a problem hiding this comment.
I think it might be better to define 2 nodes with 2 interrupts each
Member
Author
There was a problem hiding this comment.
Good catch, added more tests and actually found some bugs
cristipufu
force-pushed
the
fix/resumable_tests
branch
from
af306bd to
14e4c5d
Compare
cristipufu
force-pushed
the
fix/resumable_tests
branch
7 times, most recently
from
e213723 to
8234611
Compare
radu-mocanu
approved these changes
Dec 30, 2025
cristipufu
force-pushed
the
fix/resumable_tests
branch
from
8234611 to
43958f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the interrupt detection logic in the LangGraph runtime and adds comprehensive tests for parallel branches with triggers. The key fix changes the
_is_interruptedmethod to also check for actual interrupts (state.interrupts) rather than only scheduled nodes (state.next), which more accurately identifies when execution is truly suspended due to interrupts.Development Package