Make configuration work independent of whether appsettings json files are provided #337

ChrisDoernen · 2025-12-16T15:27:32Z

It is me again ☺️ Thanks for merging so quick! I updated to the new version and have a follow-up suggestion.

Currently the configuration is only getting built when there are appsetting files configured (GetTestAppSettings). We often have the case that our configuration is only coming from environment variables without appsettings file.

So the idea is if we can actually build the configuration regardless. This also has the advantage that the IConfiguration does not need to be nullable in AddServices. This makes it a bit nicer for the user because they don't need to check for null.

I also changed GetTestAppSettings to be virtual with a default implementation of an empty enumerable, so users don't need to override the method when they don't want to provide appsettings. This would then work like AddUserSecretes.

I adopted the configuration tests (see TestProjectFixtureWithoutAppsettings), all test are still green.

All the best

Chris

… are provided

Arash-Sabet · 2025-12-16T16:13:14Z

@ChrisDoernen You're welcome!

Right on time! I was thinking making the same change too! Please give me a couple of days to review this PR. There are some other projects heavily relying on appsettings.json file and I do not want them to break.

Can you please check something else? I remember there is a feature to accommodate the development machine's secret settings/values. Can you please verify if that feature is not broken after your change in this PR? Thanks.

ChrisDoernen · 2025-12-16T16:44:22Z

Nice! Yes sure, take your time.

I did not yet use this feature, do you mean overriding AddUserSecrets? I will do research and testing on my local machine and report back.

…assert the secrets are available in the application via configuration.

…s' into get-configuration-root-regardless

ChrisDoernen · 2025-12-16T17:35:48Z

@Arash-Sabet ok I got what you mean, check out my second commit.

I am setting the (randomized) secrets in the test and assert that they are available. However, the secrets remain set after the test did run.

For me it is not a problem and the randomization ensures no collisions. If you want me to do a clean up, I am happy to implement it.

Arash-Sabet · 2025-12-17T13:32:21Z

@ChrisDoernen I left a few comments in this PR and you can review them in the "File View" section. Resolving them paves the path for my next step.

ChrisDoernen · 2025-12-17T15:38:11Z

@Arash-Sabet I can not find the "File View" section and your comments. Can you post a screenshot where to click? I expected to view comments in the "Files Changed" tab:

Arash-Sabet · 2025-12-17T16:06:38Z

@ChrisDoernen Does not vs code display my comments if you open the changed files in it? It should I guess.

ChrisDoernen · 2025-12-17T16:21:34Z

I am working in JetBrains Rider...
But surely I should see them somewhere here in GitHub in the PR!?

ChrisDoernen · 2025-12-17T16:26:21Z

Opened it in VSCode but nothing. Can you try commenting here on Github like so? Maybe then I see them...

Arash-Sabet · 2025-12-18T14:10:00Z

@ChrisDoernen Please see the screenshots below:

…d. Then assert the secrets are available in the application via configuration." This reverts commit b4dc253.

…tings

ChrisDoernen · 2025-12-18T16:45:09Z

@Arash-Sabet I reverted my second commit and made a new one with an explicit test case for configuration without appsettings. All tests are green.

ChrisDoernen · 2025-12-20T17:52:19Z

@Arash-Sabet what do you think? TestBedFixture line 153 is the main change: We build the configuration always, not only when appsettings are used. This enables using env variables only (without appsettings).

Arash-Sabet · 2025-12-21T01:21:52Z

@ChrisDoernen Thanks. I will review it soon.

Bump .NET SDK version to 10.0.101 and increment patch/revision numbers in both Azure pipeline YAML files. Remove unnecessary blank lines in ConfigurationTestsWithoutAppsettings.cs for cleaner test code.

Update GetConfigurationRoot to ignore TestAppSettings entries with null or empty filenames when adding JSON files to the configuration builder.

Arash-Sabet · 2025-12-16T16:37:12Z

examples/Xunit.Microsoft.DependencyInjection.ExampleTests/ConfigurationTests.cs

@ChrisDoernen Can you please restore the original implementation of ConfigurationTersts class and instead add a new configuration tests class to verify TestProjectFixtureWithoutAppsettings's implementation?

Arash-Sabet · 2025-12-16T16:39:01Z

src/Abstracts/TestBedFixture.cs

+	private IConfigurationRoot GetConfigurationRoot()
 	{
 		var testAppSettings = GetTestAppSettings();
-		return


@ChrisDoernen what is the reason for removing the condition?

Arash-Sabet · 2025-12-16T18:07:59Z

examples/Xunit.Microsoft.DependencyInjection.ExampleTests/appsettings.json

 {
  "Options": {
    "Rate": 10
-  },


Hey @ChrisDoernen we did not need to remove anything or alter anything related to using secret values. Can you please undo this change?
Let's put it in this way: I will only accept this PR if the changes are incremental. I do not want to get the already-implemented feature excluded or removed unless they are obsolete.

Arash-Sabet · 2025-12-16T18:08:33Z

examples/Xunit.Microsoft.DependencyInjection.ExampleTests/SecretValues.cs

 {
-    public string? Secret1 { get; set; }
-    public string? Secret2 { get; set; }
+    public required string Secret1 { get; set; }


@ChrisDoernen the required keyword is unnecessary.

Arash-Sabet · 2025-12-16T18:09:04Z

examples/Xunit.Microsoft.DependencyInjection.ExampleTests/UserSecretTests.cs

    public void TestSecretValues()
    {
-        /*
-         * TODO: Create a user secret entry like the following payload in user secrets and remove the same from appsettings.json file:


@ChrisDoernen Please restore this block of comment

Arash-Sabet · 2025-12-16T18:09:27Z

examples/Xunit.Microsoft.DependencyInjection.ExampleTests/UserSecretTests.cs

+    {
+        SetSecret(nameof(SecretValues.Secret1), _secret1Value);
+        SetSecret(nameof(SecretValues.Secret2), _secret2Value);
+    }


@ChrisDoernen Please remove this block.

Arash-Sabet · 2025-12-16T18:09:45Z

examples/Xunit.Microsoft.DependencyInjection.ExampleTests/UserSecretTests.cs

+        Assert.Equal(secretValues.Secret2, _secret2Value);
+    }
+
+    private void SetSecret(string secretName, string secretValue)


@ChrisDoernen Unnecessary.

ChrisDoernen · 2025-12-22T09:24:01Z

Hey @Arash-Sabet, thanks so much for your work. I think it is a useful improvement, I will used it right away!

Happy holidays to you and your family!

Make configuration work independent of whether appsettings json files…

8c61cca

… are provided

Arash-Sabet self-requested a review December 16, 2025 16:13

Merge branch 'main' into get-configuration-root-regardless

7e77c4a

ChrisDoernen added 2 commits December 16, 2025 18:33

Programatically set (random) user secrets using dotnet command. Then …

b4dc253

…assert the secrets are available in the application via configuration.

Merge remote-tracking branch 'origin/get-configuration-root-regardles…

e266a22

…s' into get-configuration-root-regardless

ChrisDoernen added 2 commits December 18, 2025 17:37

Revert "Programatically set (random) user secrets using dotnet comman…

5c94822

…d. Then assert the secrets are available in the application via configuration." This reverts commit b4dc253.

Add explicit test class for testing configuration without test appset…

5fcbc46

…tings

Arash-Sabet self-assigned this Dec 21, 2025

Arash-Sabet added 2 commits December 21, 2025 09:51

Update pipeline configs and clean up test code

16600bb

Bump .NET SDK version to 10.0.101 and increment patch/revision numbers in both Azure pipeline YAML files. Remove unnecessary blank lines in ConfigurationTestsWithoutAppsettings.cs for cleaner test code.

Skip empty filenames in configuration loading

319612d

Update GetConfigurationRoot to ignore TestAppSettings entries with null or empty filenames when adding JSON files to the configuration builder.

Arash-Sabet approved these changes Dec 21, 2025

View reviewed changes

Arash-Sabet merged commit 480bce5 into Umplify:main Dec 21, 2025
1 check passed

Make configuration work independent of whether appsettings json files are provided #337

Make configuration work independent of whether appsettings json files are provided #337

Uh oh!

Conversation

ChrisDoernen commented Dec 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Arash-Sabet commented Dec 16, 2025

Uh oh!

ChrisDoernen commented Dec 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ChrisDoernen commented Dec 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Arash-Sabet commented Dec 17, 2025

Uh oh!

ChrisDoernen commented Dec 17, 2025

Uh oh!

Arash-Sabet commented Dec 17, 2025

Uh oh!

ChrisDoernen commented Dec 17, 2025

Uh oh!

ChrisDoernen commented Dec 17, 2025

Uh oh!

Arash-Sabet commented Dec 18, 2025

Uh oh!

ChrisDoernen commented Dec 18, 2025

Uh oh!

ChrisDoernen commented Dec 20, 2025

Uh oh!

Arash-Sabet commented Dec 21, 2025

Uh oh!

Arash-Sabet Dec 16, 2025

Choose a reason for hiding this comment

Uh oh!

Arash-Sabet Dec 16, 2025

Choose a reason for hiding this comment

Uh oh!

Arash-Sabet Dec 16, 2025

Choose a reason for hiding this comment

Uh oh!

Arash-Sabet Dec 16, 2025

Choose a reason for hiding this comment

Uh oh!

Arash-Sabet Dec 16, 2025

Choose a reason for hiding this comment

Uh oh!

Arash-Sabet Dec 16, 2025

Choose a reason for hiding this comment

Uh oh!

Arash-Sabet Dec 16, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ChrisDoernen commented Dec 22, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ChrisDoernen commented Dec 16, 2025 •

edited

Loading

ChrisDoernen commented Dec 16, 2025 •

edited

Loading

ChrisDoernen commented Dec 16, 2025 •

edited

Loading