enhance compute_etco2_and_ventilations(mode="filter") #256
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
August 6, 2025 07:45
…y tracing back co2 form etco2 until zero or resp_time
…not work as good as searching backwards till breath_threshold
Please enter the commit message for your changes. Lines starting
Author
|
@behackl MF |
Contributor
|
All good, thanks! Sorry, have been really busy with our local infrastructure lately; properly reviewing this is already quite far up my list. I'll try to get at least a coarse review done within a day or two! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original filter mode (KERN) detects respiration times but does not necessarily align with the physiological plausible start of exhalation. The new filter_onset mode enhances this by tracing backward from the etCO₂ peak to the chosen breath_threshold, constrained between resp_time and the etco2, providing a clinically plausible exhalation onset in noisy capnograms.