Feature/badge 기능 구현 #56 #58
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- auth에 필요없는 import 제거
- 뱃지 등록 - 뱃지 조회(전체, 유저) - 뱃지 부여 기능 - 뱃지 박탈 기능 - #56
Open
3 tasks
jasper200207
requested changes
Mar 31, 2024
Contributor
jasper200207
left a comment
jasper200207
left a comment
There was a problem hiding this comment.
뱃지 부여 및 삭제 통합하도록 코멘트 확인해주세요
src/controllers/badge.controller.ts
Outdated
Comment on lines
82
to
84
| async getBadges(): Promise<Badge[]> { | ||
| return this.badgeService.getBadges(); | ||
| } |
Contributor
There was a problem hiding this comment.
이건 어드민 권한으로 해야할 듯 합니다
Comment on lines
1
to
4
| export class GrantRequestBadgeDto { | ||
| userId: string; | ||
| badgeId: string; | ||
| } |
Contributor
There was a problem hiding this comment.
이거 형식을
export class GrantRequestBadgeDto {
userId:string;
grantedBadges:string[];
deprivedBadges:string[];
}
Comment on lines
+86
to
+96
| @Get('/:userId') | ||
| @ApiOperation({ | ||
| summary: 'Get Badges By UserId', | ||
| description: 'Get Badges By UserId', | ||
| }) | ||
| @ApiCreatedResponse({ | ||
| description: 'Badges', | ||
| }) | ||
| async getBadgesByUserId(userId: string): Promise<Badge[]> { | ||
| return this.badgeService.getBadgesByUserId(userId); | ||
| } |
Contributor
There was a problem hiding this comment.
이 부분은 유저 프로필 조호와 합칩시다
src/services/badge/badge.service.ts
Outdated
Comment on lines
69
to
73
| const badgeLog = new BadgeLog(); | ||
| badgeLog.badge = badge; | ||
| badgeLog.user = user; | ||
| badgeLog.isGiven = true; | ||
| return await this.badgeLogRepository.save(badgeLog); |
Contributor
There was a problem hiding this comment.
이건 없어도 됩니다. 디비에서 남길거에요
Comment on lines
+19
to
+20
| @InjectRepository(BadgeLog) | ||
| private readonly badgeLogRepository: Repository<BadgeLog>, |
src/services/badge/badge.service.ts
Outdated
Comment on lines
114
to
118
| const badgeLog = new BadgeLog(); | ||
| badgeLog.badge = badge; | ||
| badgeLog.user = user; | ||
| badgeLog.isGiven = false; | ||
| await this.badgeLogRepository.save(badgeLog); |
Comment on lines
+108
to
+112
| await this.userRepository | ||
| .createQueryBuilder() | ||
| .relation(User, 'badges') | ||
| .of(user) | ||
| .remove(badge); |
src/services/badge/badge.service.ts
Outdated
| // await this.badgeRepository.delete({ id: badgeId }); | ||
| // } | ||
|
|
||
| async depriveBadgeFromUser(badgeId: string, userId: string): Promise<void> { |
Contributor
There was a problem hiding this comment.
초기 생성 뱃지는 삭제안되도록 해주세요
basic 컬럼 추가해서 확인하면 될듯 합니다
…Back into Feature/Badge_기능_구현_#56
- key가 nullable이 불가능하게 설정
- badge 매개변수를 badgeId[]로 받게함 - 리스트를 받아서 한번에 저장, 박탈 - 리스트로 dto도 변환
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
관련이슈
요약
뱃지 관련 기능 생성
상세
리뷰안내