-
Notifications
You must be signed in to change notification settings - Fork 4
865 frontend create gamesessioncard and table for admin semesters view #902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
seungbeomYang
wants to merge
16
commits into
master
Choose a base branch
from
865-frontend-create-gamesessioncard-and-table-for-admin-semesters-view
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
865 frontend create gamesessioncard and table for admin semesters view #902
seungbeomYang
wants to merge
16
commits into
master
from
865-frontend-create-gamesessioncard-and-table-for-admin-semesters-view
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add AdminSemestersTable component with stories and tests - Add GameSessionCard component with stories and tests - Add AdminSemestersResponsive stories - Update Composite components index - Add AGENTS.md documentation Closes #865
6 tasks
Contributor
Preview Deployment Status🔄 Storybook Preview: Deploying... 🔄 Frontend Preview: Deploying... |
…ble-for-admin-semesters-view
…ble-for-admin-semesters-view
…and GameSessionCard - Added AdminSemestersTable to the Composite index. - Updated AdminSemestersTable stories to improve type safety and formatting. - Refactored GameSessionCard tests for better readability and consistency. - Cleaned up imports in both AdminSemestersTable and GameSessionCard components.
Contributor
Coverage Report
File CoverageNo changed files found. |
…ble-for-admin-semesters-view
- Updated export statements in Composite index to avoid name conflicts. - Enhanced type safety in AdminSemestersTable stories by defining argument types. - Simplified GameSessionCard story parameters for better alignment with session data.
…ble-for-admin-semesters-view
- Added tests for edit and delete actions in AdminSemestersTable. - Simplified onClick handlers for edit and delete actions using optional chaining. - Integrated NuqsTestingAdapter for improved test rendering.
…ble-for-admin-semesters-view
…ble-for-admin-semesters-view
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes # (issue)
Type of change
How Has This Been Tested?
Checklist before requesting a review