Skip to content

Conversation

@davidsteiner
Copy link
Member

In preparation for the overhauled message parsing logic, this change refactors the dictionary code by breaking it down into modules and renaming a few things to clarify their purpose to make it easier to add new functionality.

@davidsteiner davidsteiner linked an issue Oct 29, 2025 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Oct 29, 2025

Codecov Report

❌ Patch coverage is 69.05660% with 164 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.88%. Comparing base (452c271) to head (7c8075b).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/hotfix-dictionary/src/layout.rs 28.12% 46 Missing ⚠️
crates/hotfix-dictionary/src/field.rs 50.68% 36 Missing ⚠️
crates/hotfix-dictionary/src/datatype.rs 77.77% 32 Missing ⚠️
crates/hotfix-dictionary/src/component.rs 25.00% 18 Missing ⚠️
crates/hotfix-dictionary/src/dictionary.rs 91.12% 11 Missing ⚠️
crates/hotfix-message/src/parser.rs 0.00% 11 Missing ⚠️
crates/hotfix-dictionary/src/message_definition.rs 57.14% 9 Missing ⚠️
crates/hotfix-dictionary/src/quickfix.rs 97.05% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #222      +/-   ##
==========================================
+ Coverage   81.48%   81.88%   +0.39%     
==========================================
  Files          68       75       +7     
  Lines        6140     6115      -25     
==========================================
+ Hits         5003     5007       +4     
+ Misses       1137     1108      -29     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

DGPardo
DGPardo previously approved these changes Oct 31, 2025
david2003542
david2003542 previously approved these changes Oct 31, 2025
@davidsteiner davidsteiner dismissed stale reviews from david2003542 and DGPardo via 7c8075b October 31, 2025 09:46
@davidsteiner davidsteiner merged commit f6626f1 into main Oct 31, 2025
3 of 4 checks passed
@davidsteiner davidsteiner deleted the 221-redesigned-message-parsing-implementation branch October 31, 2025 10:15
@github-actions github-actions bot mentioned this pull request Nov 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Redesigned message parsing implementation

4 participants