-
Notifications
You must be signed in to change notification settings - Fork 3
chore: refactor dictionary implementation #222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
davidsteiner
merged 13 commits into
main
from
221-redesigned-message-parsing-implementation
Oct 31, 2025
Merged
chore: refactor dictionary implementation #222
davidsteiner
merged 13 commits into
main
from
221-redesigned-message-parsing-implementation
Oct 31, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #222 +/- ##
==========================================
+ Coverage 81.48% 81.88% +0.39%
==========================================
Files 68 75 +7
Lines 6140 6115 -25
==========================================
+ Hits 5003 5007 +4
+ Misses 1137 1108 -29 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
DGPardo
previously approved these changes
Oct 31, 2025
david2003542
previously approved these changes
Oct 31, 2025
7c8075b
DGPardo
approved these changes
Oct 31, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for the overhauled message parsing logic, this change refactors the dictionary code by breaking it down into modules and renaming a few things to clarify their purpose to make it easier to add new functionality.