Re-order ClinGen Variant Submissions #609
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refactors the job submission and error handling logic for mapping variant data and submitting it to external services (ClinGen Allele Registry and LDH). These changes necessitated a rework of how publication testing is handled to reduce duplication.
Error handling and exception cleanup:
LinkingEnqueueErrorexception class fromsrc/mavedb/lib/exceptions.pyand its imports, simplifying the exception hierarchy. [1] [2]Job submission and queue logic improvements:
publish_score_setto use more descriptive variable names (refresh_published_variants_job,submit_to_ldh_job) and improved logging context keys for better traceability.hgvs_assay_levelafter mapping completes, so it is available directly for the CAR and LDH submission jobs.link_clingen_variantsjob, as this linkage is handled directly by CAR submission.HGVS string handling and logging enhancements:
hgvs_assay_levelfield instead ofpost_mapped, and added logging for variants missing this field, improving error visibility and data integrity. [1] [2]Imports and code cleanup:
src/mavedb/worker/jobs.py, removing unused functions and exception imports, and addingfuncfor SQL operations. [1] [2]