Fixing list insert error under BSD sed #2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This was related to the FreeBSD port for
monsand the issue opened up in the portstree bugzilla: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=248632BSD sed was unable to correctly leverage
icommand resulting in the following output when runningmonsonmaster375bbba3aa700c8b3b33645a7fb70605c8b0ff0c:The following change was initially suggested by @kevans91 here: Ventto/mons#30 (comment) but I did some more testing to get the following to be compliant for both GNU and BSD versions of sed.
Tests
I have added appropriate tests for both the
libshlistandlibshlist_unsafevariations.As for
monsthis also fixes the original error. I do have an issue with howcommand -pv xrandris working and have to modify it tocommand -v xrandrbut Ill open that issue inmonsfor discussion: