Skip to content

Conversation

@zerok1986
Copy link

@zerok1986 zerok1986 commented Jan 13, 2022

Completed without styles, phone details displayed and spinner.
More than 1h stucked with react-router-dom version change from @5 to @6 and the Routing.

@RaselJam
Copy link

Well done!

@zerok1986
Copy link
Author

Thanks @RaselJam but it's far from being well done!! I spent most of the exercise time reading the documentation about react-router-dom v6... 😢 It's not even styled ... poor result, shame on me.

</h2>
</main>
<nav>
<Link to="/phones">List of Phones</Link>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggesttion : As you are using a util to store your path in utils/path. i think it will be a good idea to use it here too, insetad of hardcoded to="/phones"

Copy link
Author

@zerok1986 zerok1986 Jan 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was using but I hardcoded it when I was testing the new react-router-dom. I haven't time to use it properly in the HomePage component. Time flied yesterday... Thanks anyway for your feedback! It's always welcome! 😄

@RaselJam
Copy link

Thanks @RaselJam but it's far from being well done!! I spent most of the exercise time reading the documentation about react-router-dom v6... 😢 It's not even styled ... poor result, shame on me.

we have 6 more days to make it perfect. Rome has not been build in 3h .
About react-router-dom v6. after catching it, it will make the life a lot easier. its far better than v5.
to save you time instead of doc you may want to watch this summary : youtube
BTW as i was saying it is not in a BETA version, it has been released november 2021.
i got disapointed when i saw ironhack hadn't updated their material then.

@zerok1986
Copy link
Author

Thanks @RaselJam but it's far from being well done!! I spent most of the exercise time reading the documentation about react-router-dom v6... 😢 It's not even styled ... poor result, shame on me.

we have 6 more days to make it perfect. Rome has not been build in 3h . About react-router-dom v6. after catching it, it will make the life a lot easier. its far better than v5. to save you time instead of doc you may want to watch this summary : youtube BTW as i was saying it is not in a BETA version, it has been released november 2021. i got disapointed when i saw ironhack hadn't updated their material then.

I'm doing it as a personal project in the next 6 days too, I had in mind to style it with tailwind and make all the bonus points until the deadline. This is the start of our future as professional developers, so let's make it excellent! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants