adding sequelize ORM #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vineet-suri
reviewed
Sep 20, 2022
client/src/app/user.model.ts
Outdated
| export interface UserModel{ | ||
| user_id?: string, | ||
| id?: string, | ||
| first_name: string, |
There was a problem hiding this comment.
variable names should be camel case
Owner
Author
There was a problem hiding this comment.
variable changed in camel case
vineet-suri
reviewed
Sep 20, 2022
server/src/index.ts
Outdated
Comment on lines
19
to
21
| app.use('/user',userRouter); | ||
| app.use('/role',roleRouter); | ||
| app.use('/customer',customerRouter); |
There was a problem hiding this comment.
routes should be plural eg. /users
Owner
Author
There was a problem hiding this comment.
routes changed into plural form
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.