Refactor daemon to use rc2-core library
#27
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Backporting changes from main to the refactor branch
On a single-click of an alert tone button, the command to stop the alert would happen instantly while the delay for starting the tone was still pending, leading to an infinite tone with no ability to cancel or stop it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a major, breaking change to the RC2 daemon application which converts the legacy libraries and code to use the rc2-core libraries.
Additionally, daemon configuration is now performed using YAML files as opposed to TOML files. This means that any existing daemon config files will have to be manually converted to use the new format. Going forward this will make adding new features much easier.