Skip to content

Conversation

@dkocur
Copy link

@dkocur dkocur commented Apr 18, 2021

Hi. I've been a professional software developer for over 28 years. Recently you were kind enough to give me $5 off on this kit because one of the sensors was bad. I'd like to return the favor by providing this cleaned up and tested code.

It behaves almost exactly the same, but it is shorter and it is much easier to understand. The one functional change that I made was lowering the value used to determine whether or not to turn the pump on from 750 to 400. In my testing, the sensors would never get to 750 and therefore would never turn the pumps on.

I hope you like the changes!

@meeple142
Copy link

So much better :) thank you!

@mikez771
Copy link

Had to log in to say I love you. Product wasn't working until I made your changes and BAM! You probably saved me hours and I am forever grateful

@Grizwisky
Copy link

Just wondering if you could set this up for 10 to 12 sensors? Would I double the sensors to each port? ie... A0 has 2, A1 has 2 and so on? Or is something like that not possible?

@dkocur
Copy link
Author

dkocur commented Nov 24, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants