Skip to content

Soft Touch & Fortuna Extract fix try 2 #2148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
stellanera98 wants to merge 2 commits into
base: 1.20.1
Choose a base branch
from
Open

Soft Touch & Fortuna Extract fix try 2 #2148

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0c1eea9
try again
Dec 16, 2025
fd46052
change to ignore BE's entirely and only roll loot table again otherwise
Jan 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
84 changes: 46 additions & 38 deletions src/main/java/wayoftime/bloodmagic/loot/GlobalLootModifier.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,16 @@
import com.mojang.serialization.codecs.RecordCodecBuilder;
import it.unimi.dsi.fastutil.objects.ObjectArrayList;
import net.minecraft.core.BlockPos;
import net.minecraft.resources.ResourceLocation;
import net.minecraft.server.level.ServerLevel;
import net.minecraft.world.SimpleContainer;
import net.minecraft.world.item.ItemStack;
import net.minecraft.world.item.crafting.RecipeType;
import net.minecraft.world.item.crafting.SmeltingRecipe;
import net.minecraft.world.item.enchantment.Enchantment;
import net.minecraft.world.item.enchantment.EnchantmentHelper;
import net.minecraft.world.item.enchantment.Enchantments;
import net.minecraft.world.level.block.Block;
import net.minecraft.world.level.block.entity.BlockEntity;
import net.minecraft.world.level.block.state.BlockState;
import net.minecraft.world.level.storage.loot.LootContext;
Expand Down Expand Up @@ -50,19 +53,6 @@ public class GlobalLootModifier
public static final RegistryObject<Codec<SmeltingModifier>> SMELT = GLM.register("smelt", SmeltingModifier.CODEC);
public static final RegistryObject<Codec<VoidingModifier>> VOID = GLM.register("voiding", VoidingModifier.CODEC);

private static LootParams.Builder copyBlockNoTool(LootContext context) {
LootParams.Builder builder = new LootParams.Builder(context.getLevel());
builder.withLuck(context.getLuck());
builder.withParameter(LootContextParams.BLOCK_STATE, context.getParam(LootContextParams.BLOCK_STATE));
builder.withParameter(LootContextParams.ORIGIN, context.getParam(LootContextParams.ORIGIN));

builder.withOptionalParameter(LootContextParams.THIS_ENTITY, context.getParamOrNull(LootContextParams.THIS_ENTITY));
builder.withOptionalParameter(LootContextParams.BLOCK_ENTITY, context.getParamOrNull(LootContextParams.BLOCK_ENTITY));
builder.withOptionalParameter(LootContextParams.EXPLOSION_RADIUS, context.getParamOrNull(LootContextParams.EXPLOSION_RADIUS));

return builder;
}

private static class SilkTouchTestModifier extends LootModifier
{
public static final Supplier<Codec<SilkTouchTestModifier>> CODEC = Suppliers.memoize(() -> RecordCodecBuilder.create(inst -> codecStart(inst).apply(inst, SilkTouchTestModifier::new)));
Expand All @@ -75,15 +65,21 @@ public SilkTouchTestModifier(LootItemCondition[] conditionsIn)
@Nonnull
@Override
protected @NotNull ObjectArrayList<ItemStack> doApply(ObjectArrayList<ItemStack> generatedLoot, LootContext context) {
BMLog.DEFAULT.info("doApply!");
ItemStack ctxTool = context.getParamOrNull(LootContextParams.TOOL);
// charges use anointment differently
if (ctxTool.is(BloodMagicTags.CHARGES)) {
return generatedLoot;
}

BlockEntity be = context.getParamOrNull(LootContextParams.BLOCK_ENTITY);
// dont apply on BE's
if (be != null) {
return generatedLoot;
}

// return early if silk-touch is already applied (otherwise we'll get stuck in
// an infinite loop).
if (EnchantmentHelper.getEnchantments(ctxTool).containsKey(Enchantments.SILK_TOUCH)) {
BMLog.DEFAULT.info("silk touch present, returning data '{}'", generatedLoot.get(0).getOrCreateTag());
return generatedLoot;
}
AnointmentHolder holder = AnointmentHolder.fromItemStack(ctxTool);
Expand All @@ -94,11 +90,19 @@ public SilkTouchTestModifier(LootItemCondition[] conditionsIn)

ItemStack fakeTool = ctxTool.copy();
fakeTool.enchant(Enchantments.SILK_TOUCH, 1);
LootParams.Builder builder = copyBlockNoTool(context);
builder.withParameter(LootContextParams.TOOL, fakeTool);
LootTable lootTable = context.getLevel().getServer().getLootData().getLootTable(context.getParam(LootContextParams.BLOCK_STATE).getBlock().getLootTable());
BMLog.DEFAULT.info("loot table I guess '{}'", lootTable.getLootTableId());
return lootTable.getRandomItems(builder.create(LootContextParamSets.EMPTY));

ResourceLocation tableID = context.getQueriedLootTableId();
ServerLevel level = context.getLevel();
LootTable table = level.getServer().getLootData().getLootTable(tableID);
LootParams params = new LootParams.Builder(level)
.withParameter(LootContextParams.ORIGIN, context.getParam(LootContextParams.ORIGIN))
.withParameter(LootContextParams.BLOCK_STATE, context.getParam(LootContextParams.BLOCK_STATE))
.withParameter(LootContextParams.TOOL, fakeTool)
.withOptionalParameter(LootContextParams.THIS_ENTITY, context.getParamOrNull(LootContextParams.THIS_ENTITY))
.withLuck(context.getLuck())
.create(LootContextParamSets.BLOCK);

return table.getRandomItems(params);
}

@Override
Expand Down Expand Up @@ -128,12 +132,21 @@ public FortuneModifier(LootItemCondition[] conditionsIn)
{
return generatedLoot;
}

if (ctxTool.is(BloodMagicTags.CHARGES)) {
return generatedLoot;
}

if (EnchantmentHelper.getEnchantments(ctxTool).containsKey(Enchantments.SILK_TOUCH))
BlockEntity be = context.getParamOrNull(LootContextParams.BLOCK_ENTITY);
// dont apply on BE's
if (be != null) {
return generatedLoot;
}

if (EnchantmentHelper.getEnchantments(ctxTool).containsKey(Enchantments.SILK_TOUCH)) {
return generatedLoot;
}

AnointmentHolder holder = AnointmentHolder.fromItemStack(ctxTool);
if (holder == null)
{
Expand All @@ -154,23 +167,18 @@ public FortuneModifier(LootItemCondition[] conditionsIn)
enchants.put(Enchantments.BLOCK_FORTUNE, baseFortuneLevel + additionalFortune);
EnchantmentHelper.setEnchantments(enchants, fakeTool);

// EnchantmentHelper.setEnchantmentLevel(p_182441_, p_182442_);

LootParams.Builder builder = new LootParams.Builder(context.getLevel());
builder.withParameter(LootContextParams.TOOL, fakeTool);

Vec3 vec = context.getParam(LootContextParams.ORIGIN);
if (vec != null) {
BlockPos pos = BlockPos.containing(vec);
BlockEntity be = context.getLevel().getBlockEntity(pos);
if (be != null) {
builder.withParameter(LootContextParams.BLOCK_ENTITY, be);
}
}

LootParams ctx = builder.create(LootContextParamSets.EMPTY);
LootTable loottable = context.getLevel().getServer().getLootData().getLootTable(context.getParamOrNull(LootContextParams.BLOCK_STATE).getBlock().getLootTable());
return loottable.getRandomItems(ctx);
ResourceLocation tableID = context.getQueriedLootTableId();
ServerLevel level = context.getLevel();
LootTable table = level.getServer().getLootData().getLootTable(tableID);
LootParams params = new LootParams.Builder(level)
.withParameter(LootContextParams.ORIGIN, context.getParam(LootContextParams.ORIGIN))
.withParameter(LootContextParams.BLOCK_STATE, context.getParam(LootContextParams.BLOCK_STATE))
.withParameter(LootContextParams.TOOL, fakeTool)
.withOptionalParameter(LootContextParams.THIS_ENTITY, context.getParamOrNull(LootContextParams.THIS_ENTITY))
.withLuck(context.getLuck())
.create(LootContextParamSets.BLOCK);

return table.getRandomItems(params);
}

@Override
Expand Down