Skip to content

Early termination of formatDisplayValue for bitfield #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AkiSakurai wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Early termination of formatDisplayValue for bitfield #207

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d681cfb
Early termination of formatDisplayValue for bitfield
AkiSakurai Dec 6, 2025
ee36308
Fix formatting style for conditional check
AkiSakurai Dec 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion lib/include/pl/patterns/pattern_bitfield.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -712,6 +712,10 @@ namespace pl::ptrn {
} else if (auto *bitfield = dynamic_cast<PatternBitfield *>(pattern.get()); bitfield != nullptr) {
valueString += fmt::format("{} = {} | ", bitfield->getVariableName(), bitfield->formatDisplayValue());
}

if (valueString.size() - 3 > 64) {
break;
}
}

if (valueString.size() >= 3) {
Expand Down Expand Up @@ -810,4 +814,4 @@ namespace pl::ptrn {
bool m_reversed = false;
};

}
}
Loading