Fix file permissions for generated JSON files #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #14 - File permission issue for data-downloader generated JSON files
Problem
The data-downloader scanner was creating JSON files (runs.json, scanner_status.json, sensors.json) with restrictive permissions (-rw-------), preventing other components and the VS Code coder user from reading them. This caused "NoPermissions" errors when trying to access the files.
Solution
Modified the _write_file method in backend/storage.py to set proper file permissions using chmod(0o664). This ensures all generated JSON files have -rw-rw-r-- permissions (readable by owner, group, and others).
Changes
Updated backend/storage.py: Added tmp_path.chmod(0o664) to set group-readable permissions on temporary files before moving them to their final location