refactor: remove telegraf service and switch to direct influxdb write #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the Telegraf intermediary service and refactors the startup data loader to write directly to InfluxDB 3, simplifying the architecture and reducing the container count from 9 to 8.
Key Changes
- Eliminated the Telegraf service and its configuration file, removing the file-based line protocol intermediary
- Refactored
load_data.pyto always use direct InfluxDB writes instead of conditionally toggling between Telegraf file output and direct writes - Updated all documentation to reflect the simplified architecture without Telegraf references
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| installer/telegraf.conf | Removed entire Telegraf configuration file as service is no longer needed |
| installer/startup-data-loader/load_data.py | Removed BACKFILL mode toggle and file output logic; now always writes directly to InfluxDB |
| installer/startup-data-loader/README.md | Updated documentation to remove BACKFILL variable references |
| installer/startup-data-loader/Dockerfile | Removed telegraf directory creation commands |
| installer/docker-compose.yml | Removed telegraf service definition, volume, and environment variable |
| installer/README.md | Removed telegraf from services list and troubleshooting sections |
| docs/docker-compose.md | Updated architecture diagram and removed telegraf volume reference |
| docs/containers/telegraf.md | Removed entire telegraf documentation file |
| docs/containers/startup-data-loader.md | Removed BACKFILL mode documentation |
| docs/containers/influxdb3.md | Removed telegraf from related services list |
| docs/containers/influxdb2-legacy-build.md | Removed telegraf reference and added unclosed code fence |
| dev-utils/ci/stack-smoke-test.sh | Removed telegraf from enabled services list |
| README.md | Updated system overview to reflect 8 containers instead of 9 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
20
to
22
| For current deployments use the Docker Compose stack under `installer/`, which provisions InfluxDB 3 along with Grafana and the rest of the telemetry tooling. | ||
|
|
||
| ``` |
There was a problem hiding this comment.
This file has an unclosed code fence. There's a closing triple backtick on line 22 without a corresponding opening backtick, which will cause markdown rendering issues.
Suggested change
| For current deployments use the Docker Compose stack under `installer/`, which provisions InfluxDB 3 along with Grafana and the rest of the telemetry tooling. | |
| ``` | |
| For current deployments use the Docker Compose stack under `installer/`, which provisions InfluxDB 3 along with Grafana and the rest of the telemetry tooling. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.