Tested on DAQ Computer #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses issues with environment variable handling in the DAQ system startup process. The main problem was that the original .env file was being erased, causing the system to fall back to default passwords defined in docker-compose.
Key changes:
- Adds environment variable export at the start of the startup script to preserve existing .env values
- Simplifies the token extraction process to use a single, more reliable Docker-based method
- Updates the .env.example file with specific default passwords for the DAQ system
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| installer/scripts/start-daq-system.sh | Adds env export and simplifies token extraction to prevent .env erasure |
| installer/scripts/extract-influx-token.sh | Streamlines to use Docker-based token extraction only, removing complex fallback methods |
| installer/.env.example | Updates with specific default passwords for InfluxDB and Grafana |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
resolved token saving (now appends instead of replace whole .env)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
right now the env get erased so default passwords defined in docker-compose are being used
there might need to be an intermediate .env file that's being used by the start up script to avoid erasing the original .env