Pull in upstream #5
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re enabled in a parent config (#4864)
…a severity (#5509) The README states that a configuration like `attributes: error` is valid to only set a different severity level for a rule (the `attributes` rule here). This was previously only possible for rules that were accompanied by a plain severity configuration. I don't think this broke with the automatic parsing code generation. For some rules it might have worked before, for others not. This change makes it consistently working for all rules.
This new test ensures that rule IDs and their option names do not get changed inadvertently. The file can easily be updated by running: ```bash swift run swiftlint rules --config-only --default-config > Tests/IntegrationTests/default_rule_configurations.yml ```
While this is already implemented, it only works when a configuration is updated by calling `apply(configuration:)` on it somewhere. This imperceptible detail could lead to confusing. So better prohibit the use of the feature for the time being as long as a good solution is found. So far, no explicit configuration keys have been removed.
Co-authored-by: Danny Mösch <danny.moesch@icloud.com>
Failing immediately when a property is invalid is too strict. It feels sufficient to allow to report an issue but otherwise continue with a default value instead of stopping execution completely.
Automatically print an appropriate warning to the console.
…teral types redundant (#4756)
SourceKitten 0.35.0 Swift Argument Parser 1.3.1 SwiftSyntax 510.0.2
…nment variables (#5860)
Missing part of 7904d9a.
…parameters` rule (#5781) Co-authored-by: Danny Mösch <danny.moesch@icloud.com>
When this workflow is called from another, the event type will be the one of the caller. Therefore, checking agains `workflow_call` doesn't work.
Co-authored-by: Danny Mösch <danny.moesch@icloud.com>
Re-enable once we require Swift 6.
Killectro
force-pushed
the
pull-in-upstream
branch
from
b0c2de8 to
fbe5aef
Compare
Collaborator
|
I think this is superseded by #6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.