Add a new rule to flag GQL ID manipulation #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesonwilliams
commented
Aug 6, 2025
Source/SwiftLintBuiltInRules/Rules/RuleConfigurations/NameConfiguration.swift
Show resolved
Hide resolved
Killectro
approved these changes
Aug 6, 2025
Collaborator
Killectro
left a comment
Killectro
left a comment
There was a problem hiding this comment.
One comment but otherwise LGTM! Very excited to see this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to stop manipulating IDs that come back from the MBE GQL API surface.
Some IDs are in the format
base64("FooModelName:database_int_primary_key"), but we want to move away from this contract so that they could be, e.g., UUIDs in the future without breaking the clients.A first step is to flag all of the places in the iOS codebase where we are making assumptions about the ID content. A next step is to find other data sources for the data we're pulling out, OR if we are just passing it into other APIs, to update those APIs to be more flexible to the ID formats we actually have on hand.
Android has been flagging these usages for some time.