# Fix: Make Undo Button Clickable #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The undo button was showing up next to the submit button but wasn't actually clickable. It was just a div with some text. This PR makes it work properly. ## What Changed I converted the undo element from a non-interactive div to a proper button with an onClick handler. The keyboard shortcut (U key) was already working, so I extracted that logic into a shared `handleUndo` function that both the button and keyboard shortcut now use. The button now: - Actually responds to clicks - Gets disabled when there's nothing to undo - Uses the same logic as the keyboard shortcut for consistency Also cleaned up some TypeScript strict mode errors and lint warnings while I was in there.
WilsonNet
reviewed
Dec 1, 2025
| [gameState.status, selectedSlots] | ||
| ); | ||
|
|
||
| const handleUndo = useCallback((): void => { |
Owner
There was a problem hiding this comment.
we have react compiler here but I guess it does not hurt
WilsonNet
approved these changes
Dec 1, 2025
Owner
WilsonNet
left a comment
WilsonNet
left a comment
There was a problem hiding this comment.
Tested and it is working nice, good coe
Contributor
Author
|
Thanks! Love the project, and contributing may remind me to use it more :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The undo button was showing up next to the submit button but wasn't actually clickable. It was just a div with some text. This PR makes it work properly.
What Changed
I converted the undo element from a non-interactive div to a proper button with an onClick handler. The keyboard shortcut (U key) was already working, so I extracted that logic into a shared
handleUndofunction that both the button and keyboard shortcut now use.The button now:
Also cleaned up some TypeScript strict mode errors and lint warnings while I was in there.