Use fail instead of error #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
treeowl
force-pushed
the
fail-not-error
branch
from
fbc69d7 to
dbb9d5f
Compare
`error` in Template Haskell splices should be used to report bugs in the Template Haskell code, and ideally not to report bugs in the user code calling it. When GHC encounters `error`, it gives a rather more verbose (and ugly) error report, based on that assumption. The usual way to report a problem in this context is to use `fail`.
treeowl
force-pushed
the
fail-not-error
branch
from
dbb9d5f to
b363051
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
errorin Template Haskell splices should be used to report bugs in the Template Haskell code, and ideally not to report bugs in the user code calling it. When GHC encounterserror, it gives a rather more verbose (and ugly) error report, based on that assumption. The usual way to report a problem in this context is to usefail.