Skip to content

Conversation

@Xymanek
Copy link
Member

@Xymanek Xymanek commented Feb 7, 2020

Based on discord suggestion by @robojumper, only affects abilities that use a scripted style(s)

Demo: Xymanek@36c5b96

[0107.18] CreateAbilityStateFromTemplate: HoloTargeting state created default
[0107.18] CreateAbilityStateFromTemplate: ChainShot state created default
[0107.18] CreateAbilityStateFromTemplate: HailOfBullets state created custom
[0107.18] CreateAbilityStateFromTemplate: BulletShred state created default
[0115.41] Log: X2TacticalGameRuleset_0 TurnPhase_UnitActions: Check for Available Actions
[0115.41] GatherAbilityTargets: Entered script version for HailOfBullets
[0115.41] X2AbilityTarget_Scripted: GetPrimaryTargetOptions
[0115.41] X2AbilityTarget_Scripted: CheckFilteredPrimaryTargets
[0115.41] ScriptLog: XComTacticalInput.uc, Transition to/from State None detected. BeginState ActiveUnit_Moving from None

cc @Iridar (I did this to prove you wrong :trollface: ), @pledbrook (I know LW2 needed this)

@Xymanek Xymanek requested a review from robojumper February 7, 2020 10:16
@Xymanek
Copy link
Member Author

Xymanek commented Feb 7, 2020

Needs tracking issue and docs, @Iridar?

image

Copy link
Member

@robojumper robojumper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The addition of the _Scripted classes is unnecessarily complicated. We control all native classes, so creating a hardcoded list of native target styles is viable. This would make the solution more "plug-and-play" and would also allow people to subclass existing native target styles, potentially calling the super functions or patching existing target styles from foreign templates using the new-with-template syntax.

P.S.: I don't suppose there's a way to easily find out whether a class is native? THERE IS: #764

@Xymanek
Copy link
Member Author

Xymanek commented Feb 8, 2020

Currently waiting for #764 to be merged

@pledbrook pledbrook added the waiting-on-author A pull request is waiting on changes from the author label Apr 13, 2020
@pledbrook
Copy link
Contributor

#764 has been merged

@Musashi1584 Musashi1584 added this to the 1.21.0 milestone Apr 13, 2020
@Musashi1584 Musashi1584 modified the milestones: 1.21.0, 1.22.0 Jun 1, 2020
@robojumper
Copy link
Member

Closing in favor of #918.

@robojumper robojumper closed this Oct 29, 2020
@robojumper robojumper removed the waiting-on-author A pull request is waiting on changes from the author label Oct 29, 2020
@robojumper robojumper removed this from the 1.22.0 milestone Feb 7, 2021
@Xymanek Xymanek deleted the script-targeting-style branch June 16, 2021 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants