Cw1 md5 #4
Open
Cw1 md5 #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… statistics; model now checks for if player won.
dzharkov
reviewed
May 2, 2018
dzharkov
left a comment
dzharkov
left a comment
There was a problem hiding this comment.
По коду особо претензий нет. Однако PR оформлен плохо: при ревью пришлось продираться сквозь полотно кода из другого задания. -0.5
Итого: 9.5/10
| } | ||
|
|
||
| @SuppressWarnings("WeakerAccess") | ||
| public IOException getExecutionException() { |
There was a problem hiding this comment.
Я бы лучше пробросил завернутое исключение, но настаивать не буду
| final ArrayList<MD5EvaluatorTask> innerTasks = new ArrayList<>(); | ||
|
|
||
| md.update(path.getFileName().toString().getBytes()); | ||
| try { |
There was a problem hiding this comment.
Раз уж IO-исключение могло произойти только в walk, ты я бы этот вызов и обернул в try-catch, чтобы не усложнять читаемость содержательного куска кода
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.