Skip to content

Conversation

@X-Ryl669
Copy link
Contributor

@X-Ryl669 X-Ryl669 commented Dec 6, 2025

Since it's a deprecated empty shim that was removed in newer boost packaging.

Problem solved by the commit

Current master doesn't build on Arch linux and latest kernel because of the Boost System dependency package in CMake.
Boost system is an empty package, there's no sources or headers in it and it's only present for a small period so it doesn't break legacy code depending on it. Many rolling release distributions have removed it so it doesn't build if you rely on it.

Bug / issue (if any) fixed, which PR introduced the bug, how it was discovered

I haven't created an issue for it, but will do if required.

How problem was solved, alternative solutions (if any) and why they were rejected

I've remove the dependency since it was useless anyway.

Risks (if any) associated the changes in the commit

On very very old system, where Boost System was not empty, this could break. However, it's unlikely such system would build the current driver due to their aging kernel.

What has been tested and how, request additional testing if necessary

It fixes a build issue, no actual code was modified, so it's unlikely to break the driver features

Documentation impact (if any)

@xrt-pr-bot
Copy link

xrt-pr-bot bot commented Dec 6, 2025

⚠️ Authorization Failed

@X-Ryl669 is not a repository collaborator.

To proceed:

  • XRT Admins: Add the build label to authorize this PR build
  • OR Add @X-Ryl669 as a repository collaborator

…him that was removed in newer boost packaging

Signed-off-by: X-Ryl669 <boite.pour.spam@gmail.com>
@xrt-pr-bot
Copy link

xrt-pr-bot bot commented Dec 6, 2025

⚠️ Authorization Failed

@X-Ryl669 is not a repository collaborator.

To proceed:

  • XRT Admins: Add the build label to authorize this PR build
  • OR Add @X-Ryl669 as a repository collaborator

@stsoe stsoe added the build label Dec 9, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 9, 2025

clang-tidy review says "All clean, LGTM! 👍"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants