Feat (equalize): option to disable fused block rotations #1438
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for this PR
The current implementation applies block rotations uniformly to both online and fused rotation matrices when
block_rotation_dimis specified. However, there are scenarios where it's beneficial to apply block rotations only to online matrices while keeping fused rotations as full-vector Hadamard matrices. This PR addresses the need for control over such rotation strategies, allowing users to selectively disable block rotations for fused rotations while maintaining them for online rotations.Changes Made in this PR
disable_block_rotation_for_fusedto control block rotations in_compute_rotations--disable-block-rotation-for-fusedto the argument parserTesting Summary
Risk Highlight
Checklist
devbranch.