make get3DTransform return void #89
Conversation
| newBone = super.get3DTransform(newBone); | ||
| super.get3DTransform(newBone); | ||
| transformBone(newBone); | ||
| bone.copyOtherBone(newBone); |
There was a problem hiding this comment.
The reason for the change was that for example here instead of applying newBone to bone you can just return newBone
But I guess I forgot to do that here...
Originally get3DTransform actually returned void very early in development
There was a problem hiding this comment.
let it return void again
There was a problem hiding this comment.
You gotta acknowledge that the way I did it has some advantages
I recognize it returning void also has it's own advantages, but at this point we gotta really consider if the change is worthwhile given the existence of multi version projects that might suffer
There was a problem hiding this comment.
The problems of multi-version projects are not our problems.
Returning the bone back creates confusing, and personally, I don't understand how to use it correctly.
Some people may return the wrong bone, and we will never know.
There was a problem hiding this comment.
Multi-version projects may simply not use the return value
There was a problem hiding this comment.
I have personally had issues with returning the wrong bone and then getting stumped about why shit isn't working
I was about to write a paragraph about multi-version projects, but like now that I think about it fuck that
I never understood why it returns the bone back, it's so confusing