Bezier fixes #90
Open
Bezier fixes #90
+23
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dima-dencep
requested changes
Jan 2, 2026
core/src/main/java/com/zigythebird/playeranimcore/loading/AnimationLoader.java
Show resolved
Hide resolved
dima-dencep
approved these changes
Jan 2, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So my dumbass converted all the values in the bezier easing from degrees to radians, even the fucking pos and scale values
Now I have moved that logic to the animation loader, but that causes an issue where now you can't use MoLang for bezier rotation easing args (but to be fair neither Blockbench nor Blender support that)
We could also just export all the bezier rotation values as radians rather than beziers so no conversion is needed, but then we'd kind of be breaking the rules of the Bedrock format that always uses degrees it'd be inconsistent