PREAPPS-7580 Change Zimlet loading mechanism for supporting Content Security Policy #232
+35
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damini-vashishtha
force-pushed
the
PREAPPS-7580
branch
from
604c8fb to
9a19ed4
Compare
damini-vashishtha
changed the title
miteshsavani810
approved these changes
Jul 15, 2024
sitaram-mulik-synacor
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The name function for zimlet identification has been updated in IIFE and pass the zimlet code and its name to the getZimlet function.
Important Note: This change requires rebuilding and redeploying existing zimlets due to the changes of zimlet building (in zimlet-cli)
Please review this for more clarity: https://github.com/Zimbra/zm-x-web/pull/5079