Skip to content

fix[live-objects]: replace unsafe array cast with .map #1152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ttypic merged 1 commit into from
Aug 19, 2025
Merged

fix[live-objects]: replace unsafe array cast with .map #1152

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions live-objects/src/main/kotlin/io/ably/lib/objects/serialization/DefaultSerialization.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
@file:Suppress("UNCHECKED_CAST")

package io.ably.lib.objects.serialization

import com.google.gson.*
Expand All @@ -23,7 +21,7 @@ internal class DefaultObjectsSerializer : ObjectsSerializer {
}

override fun writeMsgpackArray(objects: Array<out Any>, packer: MessagePacker) {
val objectMessages: Array<ObjectMessage> = objects as Array<ObjectMessage>
val objectMessages = objects.map { it as ObjectMessage }
packer.packArrayHeader(objectMessages.size)
objectMessages.forEach { it.writeMsgpack(packer) }
}
Expand All @@ -36,7 +34,7 @@ internal class DefaultObjectsSerializer : ObjectsSerializer {
}

override fun asJsonArray(objects: Array<out Any>): JsonArray {
val objectMessages: Array<ObjectMessage> = objects as Array<ObjectMessage>
val objectMessages = objects.map { it as ObjectMessage }
val jsonArray = JsonArray()
for (objectMessage in objectMessages) {
jsonArray.add(objectMessage.toJsonObject())
Expand Down
Loading