Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@absmartly/javascript-sdk",
"version": "1.13.1",
"version": "1.13.2",
"description": "A/B Smartly Javascript SDK",
"homepage": "https://github.com/absmartly/javascript-sdk#README.md",
"bugs": "https://github.com/absmartly/javascript-sdk/issues",
Expand Down
7 changes: 7 additions & 0 deletions src/__tests__/utils.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,12 @@ import {
stringToUint8Array,
} from "../utils";

class SomeClass {}

describe("isObject()", () => {
it("should return true with objects", (done) => {
expect(isObject({})).toBe(true);
expect(isObject(new Object())).toBe(true);

done();
});
Expand All @@ -25,6 +28,8 @@ describe("isObject()", () => {
expect(isObject(false)).toBe(false);
expect(isObject("str")).toBe(false);
expect(isObject(new Uint8Array(1))).toBe(false);
expect(isObject(new Map())).toBe(false);
expect(isObject(new SomeClass())).toBe(false);

done();
});
Expand All @@ -45,6 +50,8 @@ describe("isNumeric()", () => {
expect(isNumeric(false)).toBe(false);
expect(isNumeric([])).toBe(false);
expect(isNumeric({})).toBe(false);
expect(isNumeric(new Object())).toBe(false);
expect(isNumeric(new Map())).toBe(false);

done();
});
Expand Down
7 changes: 6 additions & 1 deletion src/utils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,12 @@ export function isNumeric(value: unknown): value is number {
}

export function isObject(value: unknown): value is Record<string, unknown> {
return value instanceof Object && value.constructor === Object;
if (!(value instanceof Object)) {
return false;
}

const proto = Object.getPrototypeOf(value);
return proto == null || proto === Object.prototype;
}

export function isPromise(value: unknown): value is Promise<unknown> {
Expand Down