Cleanup factory from Template::Grammar #202
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atoomic
force-pushed
the
master
branch
5 times, most recently
from
0c2da20 to
e0d5f00
Compare
atoomic
force-pushed
the
reset-factory
branch
2 times, most recently
from
604c662 to
f8b9b92
Compare
Resolves abw#147 This is providing a unit test to check memory leak from the provided sample from RT 49456 Test::LeakTrace do detect a leak from the provided sample, but this is not really a leak, this is just coming from the fact that Template::Grammar is not reseting its singleton factory object. This commit adds a 'convoluted' technique to clear the singleton on DESTROY when it makes sense. Upstream-URL: abw#147
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #147
This is providing a unit test to check memory leak
from the provided sample from RT 49456
Test::LeakTrace do detect a leak from the provided sample,
but this is not really a leak, this is just coming from the
fact that Template::Grammar is not reseting its singleton factory
object.
This commit adds a 'convoluted' technique to clear the singleton
on DESTROY when it makes sense.
Upstream-URL: #147