Update tracy-client #92
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I think the CI failure isn't mine |
Owner
|
I suspect Advapi32.lib is not being linked but should be. Possibly something else was pulling that in and isn't anymore. This is an upstream problem for the optick crate. It probably needs a build.rs that links Advapi32.lib. I think I'll just remove optick from CI. It's a really nice profiler, but it doesn't look like it's maintained anymore. |
|
ok |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tracy-client 0.18.1 bumped tracy-client-sys from 0.24.3 to 0.25.0, so an update in
profilingis required to be able to use it together with the new tracy-client (you can't have two -sys copies in the dependency tree).