-
Notifications
You must be signed in to change notification settings - Fork 7
Overhaul team page #75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some Notes
- There are a few typos and inconsistencies:
- "Experience Leader" vs "Technical Lead". I recommend sticking with the "[team name] Lead" title for all of them.
- "Logistics Leaader" is misspelled.
- The spreadsheet needs to be updated with correct officer information. Several officers are no longer part of the HackUTD team.
- This doesn't resolve all the ideas in #56, notably the ability to filter based on team. See the ACM website for what the issue had in mind.
Design Suggestions
- The page could be better structured. On desktop, it doesn't efficiently use space and only displays two officers on page load. The team leads display in a single column which leaves a lot of whitepsace. I recommend:
- Keeping team leads with their respective teams or displaying them all in one section with multiple cards in horizontal rows
- Updating the cards to use Tailwind CSS breakpoints to allow three cards per row for all other sections on desktop
- The underlines beneath the titles are redundant and can safely be removed.
- The margins between the end of each section and the title for the next should be increased to better distinguish between them and increase readability.
Also, the original copy of this page had titles on each card. What were the motivations behind removing them?
This pr is still a WIP, I just changed its status to test whether or not I could approve pr's, but thanks for the feedback |
WIP