Add proper suspense boundaries #194
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR improves the user experience by implementing proper suspense boundaries for loading states. It adds a dedicated loading component for the admin section and removes unnecessary suspense wrapping from the ScheduleTimeline component that was previously handled elsewhere.
Key changes:
- Created a dedicated loading component for the admin route
- Removed manual Suspense wrapping around ScheduleTimeline in two schedule pages
- Converted ScheduleTimeline from client to server component
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| apps/web/src/app/admin/loading.tsx | Adds centralized loading component for admin routes |
| apps/web/src/app/schedule/page.tsx | Removes manual Suspense wrapper around ScheduleTimeline |
| apps/web/src/app/dash/schedule/page.tsx | Removes manual Suspense wrapper around ScheduleTimeline |
| apps/web/src/app/dash/schedule/schedule-timeline.tsx | Converts from client to server component |
| apps/web/src/components/events/admin/EventDetails.tsx | Contains unrelated character addition |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
It is important to use proper suspense boundaries for the best user experience possible.
What
loading.tsxfor admin sideSatisfies